[FFmpeg-cvslog] r14412 - trunk/libavcodec/avcodec.h

[Dominik 'Rathann' Mierzejewski]

On Saturday, 26 July 2008 at 14:20, pross at xvid.org wrote:
> On Sat, Jul 26, 2008 at 01:57:22PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > On Saturday, 26 July 2008 at 10:48, pross wrote:
> > > Author: pross
> > > Date: Sat Jul 26 10:48:26 2008
> > > New Revision: 14412
> > > 
> > > Log:
> > > add sample_fmts infrastructure: AVCodec->sample_fmts and SAMPLE_FMT_NB enum.
> > > 
> > > Modified:
> > >    trunk/libavcodec/avcodec.h
> > > 
> > > Modified: trunk/libavcodec/avcodec.h
> > > ==============================================================================
> > > --- trunk/libavcodec/avcodec.h	(original)
> > > +++ trunk/libavcodec/avcodec.h	Sat Jul 26 10:48:26 2008
> > > @@ -347,6 +347,7 @@ enum SampleFormat {
> > >      SAMPLE_FMT_S24,             ///< signed 24 bits
> > >      SAMPLE_FMT_S32,             ///< signed 32 bits
> > >      SAMPLE_FMT_FLT,             ///< float
> > > +    SAMPLE_FMT_NB               ///< Number of sample formats. DO NOT USE if dynamically linking to libavcodec
> > 
> > Huh? Why not?
> 
> Because your user application will need to be recompiled whenever we add
> another format. These rules also apply to PIXEL_FMT_NB.

Wouldn't that be ABI breakage?

R.

-- 
MPlayer http://mplayerhq.hu | Livna http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan