[FFmpeg-cvslog] r12577 - trunk/configure

[Diego Biurrun]

On Tue, Mar 25, 2008 at 03:02:50PM +0000, M?ns Rullg?rd wrote:
> 
> Diego Biurrun wrote:
> > On Tue, Mar 25, 2008 at 11:02:20AM +0000, M?ns Rullg?rd wrote:
> >>
> >> diego wrote:
> >> >
> >> > Log:
> >> > Introduce --disable-logging option to control logging.  --logfile now just
> >> > controls the name of the log file, not the decision whether or not to log.
> >> >
> >> > --- trunk/configure	(original)
> >> > +++ trunk/configure	Tue Mar 25 10:53:49 2008
> >> > @@ -1304,13 +1306,10 @@ TMPH="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$
> >> >
> >> > -if ! disabled logging ; then
> >> > -    enabled logging || logfile="$logging"
> >> > +enabled logging || logfile=/dev/null
> >>
> >> This is wrong.  Options are unset by default, i.e. neither enabled nor
> >> disabled.  Change that to "disabled logging && ..." instead.
> >
> > Not this option, see configure:870:
> >
> >   enable logging
> 
> Well, if you make the change I suggested, that line can be deleted.

It's a little harder than that, but yes, it can be done.

> And deleting is fun, right?

:)

Diego