[FFmpeg-cvslog] r13488 - trunk/libavformat/yuv4mpeg.c

[Michael Niedermayer]

On Wed, May 28, 2008 at 02:51:51PM +0200, Benjamin Larsson wrote:
> Michael Niedermayer wrote:
> > On Wed, May 28, 2008 at 02:23:08PM +0200, Benjamin Larsson wrote:
> >   
> >> Benjamin Larsson wrote:
> >>     
> >>> Michael Niedermayer wrote:
> >>>   
> >>>       
> >>>> On Wed, May 28, 2008 at 10:20:50AM +0200, Benjamin Larsson wrote:
> >>>>   
> >>>>     
> >>>>         
> >>>>> michael wrote:
> >>>>>     
> >>>>>       
> >>>>>           
> >>>>>> Author: michael
> >>>>>> Date: Wed May 28 03:57:19 2008
> >>>>>> New Revision: 13488
> >>>>>>
> >>>>>> Log:
> >>>>>> Null pointer check / CID26.
> >>>>>>
> >>>>>>   
> >>>>>>       
> >>>>>>         
> >>>>>>             
> >>>>> Coverity ID's aren't unique, you have to reference by Run also to make 
> >>>>> them unique. 
> >>>>>     
> >>>>>       
> >>>>>           
> >>>> :(
> >>>>
> >>>>
> >>>>   
> >>>>     
> >>>>         
> >>>>> We should also mandate that Coverity found bugs that we fix 
> >>>>> should be committed in a uniform way so that we easily can gather 
> >>>>> statistics from the svn log.
> >>>>>     
> >>>>>       
> >>>>>           
> >>>> Fine with me, as soon as someone comes up with a uniform way and commits
> >>>> it to our docs ill follow it.
> >>>>   
> >>>>     
> >>>>         
> >>> And please close the bugs you fix. Just set the status to Resolved in 
> >>> the webinterface.
> >>>
> >>> MvH
> >>> Benjamin Larsson
> >>>
> >>>   
> >>>       
> >> Ignore me, I just didn't see the numbers change on the front page.
> >>     
> >
> > I know, http://scan.coverity.com/rung1.html still lists 0 fixed while
> > we have half dealt with already.
> > Though then i think 80% of the warnings are duplicates of of the
> > adpcm trellis issue with 1<<trellis overflowing.
> >
> > And more oddly ffmpeg is listed at
> > rung0 and rung1 ...
> >   
> 
> Strange, anyway I propose that we attend to all issues and then request 
> to have us moved to rung 2, or at least a newer ffmpeg build.

yes, i just hope i dont have to go over all the 1<<trellis again. But my gut
feeling tells me coverity will not realize that the check in init prevents
the issue.

btw for all thouse without coverity access:
current statistics:

Checker Summary
			Count 	Percent of total
DEADCODE 		3 	2.54%
FORWARD_NULL 		17 	14.41%
NEGATIVE_RETURNS 	4 	3.39%
NULL_RETURNS 		9 	7.63%
OVERRUN_STATIC 		63 	53.39%
RESOURCE_LEAK 		14 	11.86%
REVERSE_INULL 		0 	0.00%
REVERSE_NEGATIVE 	1 	0.85%
UNINIT 			4 	3.39%
USE_AFTER_FREE 		3 	2.54%

Status Summary
		Count 	Percent of total
BUG 		5 	3.50%
FALSE 		24 	16.78%
IGNORE 	    	1 	0.70%
PENDING 	0 	0.00%
RESOLVED 	69 	48.25%
UNINSPECTED 	44 	30.77%

(and most of the resolved are duplicates i think)
 
[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080528/b6aeee68/attachment.pgp>