[FFmpeg-cvslog] r13565 - trunk/ffmpeg.c

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sat, May 31, 2008 at 01:04:14PM +0100, M?ns Rullg?rd wrote:
>> michael <subversion at mplayerhq.hu> writes:
>> 
>> > Author: michael
>> > Date: Fri May 30 22:30:29 2008
>> > New Revision: 13565
>> >
>> > Log:
>> > remove incorrect useage of av_free_static(), ffmpeg.c is not a
>> > windows dll which can be unloaded and loaded again.
>> >
>> > Modified:
>> >    trunk/ffmpeg.c
>> >
>> > Modified: trunk/ffmpeg.c
>> > ==============================================================================
>> > --- trunk/ffmpeg.c	(original)
>> > +++ trunk/ffmpeg.c	Fri May 30 22:30:29 2008
>> > @@ -392,8 +392,6 @@ static int av_exit(int ret)
>> >      for(i=0;i<nb_input_files;i++)
>> >          av_close_input_file(input_files[i]);
>> >
>> > -    av_free_static();
>> > -
>> 
>> Calling this even if not strictly necessary, makes finding memory
>> leaks with valgrind easier.
>
> I know, i was thinking it would be an incentive to remove the remainging uses
> of realloc_static(), mallocz_static() being already gone ...
>
> Its basically just changing init_vlc(....,1/INIT_VLC_USE_STATIC) to
> INIT_VLC_STATIC() or init_vlc(..., INIT_VLC_USE_NEW_STATIC)
>
> If there wouldnt be >100 i would likely just do it myself, but iam not
> motivated enough ATM for that kind of assembly line work.

If the goal is to finally get rid of it completely, I'm all for it.

-- 
M?ns Rullg?rd
mans at mansr.com