[FFmpeg-cvslog] r15741 - trunk/doc/general.texi

Michael Niedermayer michaelni
Wed Oct 29 10:56:54 CET 2008


On Wed, Oct 29, 2008 at 07:48:59AM +0100, diego wrote:
> Author: diego
> Date: Wed Oct 29 07:48:59 2008
> New Revision: 15741
> 
> Log:
> Add 'make checkheaders' to developer guidelines and patch checklist.

Could you please refrain from changing the developer policy as you see
fit!
This isnt the first time you do this. Noone else is doing this either,
even i as project leader give people reasonable time to comment to
proposed changes, and then refrain from changing if there is a majority
against it.

Now besides skiping others oppinions ...

This change is bad because
It adds one more point to a already rather long list, and one that is
really silly. 
If there is a general agreement / majority in favor of running make
checkheaders, then we should have a single target in the Makefile that
runns all tests (regression & checkheaders) and this should be in the
policy & checklist. Its 1 point instead of 2 and otherwise does the
same.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20081029/f908028f/attachment.pgp>



More information about the ffmpeg-cvslog mailing list