[FFmpeg-cvslog] r15741 - trunk/doc/general.texi
Diego Biurrun
diego
Wed Oct 29 23:54:41 CET 2008
On Wed, Oct 29, 2008 at 10:56:54AM +0100, Michael Niedermayer wrote:
> On Wed, Oct 29, 2008 at 07:48:59AM +0100, diego wrote:
> >
> > Log:
> > Add 'make checkheaders' to developer guidelines and patch checklist.
>
> Now besides skiping others oppinions ...
>
> This change is bad because
> It adds one more point to a already rather long list, and one that is
> really silly.
I keep telling people that their patches need to pass 'make
checkheaders' during reviews. Compn pointed out that this should really
be listed in the policy/checklist. That was all.
> If there is a general agreement / majority in favor of running make
> checkheaders, then we should have a single target in the Makefile that
> runns all tests (regression & checkheaders) and this should be in the
> policy & checklist. Its 1 point instead of 2 and otherwise does the
> same.
I will add such a target in a moment.
Diego
More information about the ffmpeg-cvslog
mailing list