[FFmpeg-cvslog] r19728 - in trunk/libavcodec: dsputil.c dsputil.h twinvq.c x86/dsputil_mmx.c

[Reimar Döffinger]

On Thu, Aug 27, 2009 at 05:56:03PM +0200, Vitor Sessak wrote:
> Reimar D?ffinger wrote:
> > On Thu, Aug 27, 2009 at 04:49:37PM +0200, vitor wrote:
> >> +    void (*vector_clipf)(float *dst /* align 16 */, float *src /* align 16 */, float min, float max, int len /* align 16 */);
> > 
> > Uh, wtf? I don't think there is any way to align "len" to 16 bytes...
> > Btw. why isn't src const?
> 
> Marked src as const and added early-clobber to "i" var. Saying len is 
> align 16 looked sane me (in the FFALIGN() sense), but I'm not against of 
> changing it to "/* multiple of 16 */".

Align isn't used anywhere in that way, so yes "multiple of 16" is
better.
Though a doxygen comment that properly describes all this would be even
better.