[FFmpeg-cvslog] r20817 - trunk/libavcodec/libtheoraenc.c

[Reimar Döffinger]

On Sat, Dec 12, 2009 at 09:18:49PM +0100, conrad wrote:
> Author: conrad
> Date: Sat Dec 12 21:18:49 2009
> New Revision: 20817
> 
> Log:
> Clarify comment: although still hacky, it is correct for existing libtheora
> 
> Modified:
>    trunk/libavcodec/libtheoraenc.c
> 
> Modified: trunk/libavcodec/libtheoraenc.c
> ==============================================================================
> --- trunk/libavcodec/libtheoraenc.c	Sat Dec 12 21:18:46 2009	(r20816)
> +++ trunk/libavcodec/libtheoraenc.c	Sat Dec 12 21:18:49 2009	(r20817)
> @@ -336,7 +336,8 @@ static int encode_frame(AVCodecContext* 
>      }
>      memcpy(outbuf, o_packet.packet, o_packet.bytes);
>  
> -    // HACK: does not take codec delay into account (neither does the decoder though)
> +    // HACK: assumes no encoder delay, this is true until libtheora becomes
> +    // multithreaded (which will be disabled unless explictly requested)
>      avc_context->coded_frame->pts = frame->pts;

Well, it fails to mention another issue though: Since the encoder does not know
the PTS, bitrate-encoding only works for fixed FPS, for variable FPS the resulting
bitrate is unlikely to have anything to do with what was specified.