[FFmpeg-cvslog] r18187 - trunk/configure

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Wed, Mar 25, 2009 at 06:18:22PM +0000, M?ns Rullg?rd wrote:
>> diego <subversion at mplayerhq.hu> writes:
>> >
>> > Log:
>> > cosmetics: Group all path variables together in config.mak.
>> >
>> > --- trunk/configure	Wed Mar 25 15:19:22 2009	(r18186)
>> > +++ trunk/configure	Wed Mar 25 18:46:25 2009	(r18187)
>> > @@ -2366,6 +2366,9 @@ echo "INCDIR=\$(DESTDIR)$incdir" >> conf
>> >  echo "DATADIR=\$(DESTDIR)$datadir" >> config.mak
>> >  echo "MANDIR=\$(DESTDIR)$mandir" >> config.mak
>> > +echo "SRC_PATH=\"$source_path\"" >> config.mak
>> > +echo "SRC_PATH_BARE=$source_path" >> config.mak
>> > +echo "BUILD_ROOT=\"$PWD\"" >> config.mak
>> >  echo "CC=$cc" >> config.mak
>> >  echo "AS=$as" >> config.mak
>> > @@ -2470,9 +2473,6 @@ if enabled small; then
>> >      echo "#define av_always_inline"  >> $TMPH
>> >  fi
>> >
>> > -echo "SRC_PATH=\"$source_path\"" >> config.mak
>> > -echo "SRC_PATH_BARE=$source_path" >> config.mak
>> > -echo "BUILD_ROOT=\"$PWD\"" >> config.mak
>> 
>> What was the point of this change?  Those two groups were in no way
>> related.
>
> The path variables were previously at the very end of common.mak.  It
> was a nuisance to scroll past the hundreds of format-specific variables
> to see them.

I see your point.

> Thus I decided to move them before all the format-specific
> variables.  Next to the other path variables seemed as good a place
> as any.

I would still not group them all under the name of path variables.

-- 
M?ns Rullg?rd
mans at mansr.com