[FFmpeg-cvslog] r20433 - in trunk/libavcodec: mjpegdec.c mjpegdec.h

[michael]

Author: michael
Date: Mon Nov  2 15:12:25 2009
New Revision: 20433

Log:
Avoid huge array for rgb ljpeg on the stack.
Code tested with an ljpeg i had laying around.

Modified:
   trunk/libavcodec/mjpegdec.c
   trunk/libavcodec/mjpegdec.h

Modified: trunk/libavcodec/mjpegdec.c
==============================================================================
--- trunk/libavcodec/mjpegdec.c	Mon Nov  2 01:10:10 2009	(r20432)
+++ trunk/libavcodec/mjpegdec.c	Mon Nov  2 15:12:25 2009	(r20433)
@@ -616,13 +616,13 @@ static int decode_block_refinement(MJpeg
 
 static int ljpeg_decode_rgb_scan(MJpegDecodeContext *s, int predictor, int point_transform){
     int i, mb_x, mb_y;
-    uint16_t buffer[32768][4];
+    uint16_t (*buffer)[4];
     int left[3], top[3], topleft[3];
     const int linesize= s->linesize[0];
     const int mask= (1<<s->bits)-1;
 
-    if((unsigned)s->mb_width > 32768) //dynamic alloc
-        return -1;
+    av_fast_malloc(&s->ljpeg_buffer, &s->ljpeg_buffer_size, (unsigned)s->mb_width * 4 * sizeof(s->ljpeg_buffer[0][0]));
+    buffer= s->ljpeg_buffer;
 
     for(i=0; i<3; i++){
         buffer[0][i]= 1 << (s->bits + point_transform - 1);
@@ -1504,6 +1504,8 @@ av_cold int ff_mjpeg_decode_end(AVCodecC
 
     av_free(s->buffer);
     av_free(s->qscale_table);
+    av_freep(&s->ljpeg_buffer);
+    s->ljpeg_buffer_size=0;
 
     for(i=0;i<2;i++) {
         for(j=0;j<4;j++)

Modified: trunk/libavcodec/mjpegdec.h
==============================================================================
--- trunk/libavcodec/mjpegdec.h	Mon Nov  2 01:10:10 2009	(r20432)
+++ trunk/libavcodec/mjpegdec.h	Mon Nov  2 15:12:25 2009	(r20433)
@@ -102,6 +102,9 @@ typedef struct MJpegDecodeContext {
 
     int cur_scan; /* current scan, used by JPEG-LS */
     int flipped; /* true if picture is flipped */
+
+    uint16_t (*ljpeg_buffer)[4];
+    unsigned int ljpeg_buffer_size;
 } MJpegDecodeContext;
 
 int ff_mjpeg_decode_init(AVCodecContext *avctx);