[FFmpeg-cvslog] r20489 - trunk/libavcodec/celp_filters.c

rbultje subversion
Mon Nov 9 23:04:03 CET 2009


Author: rbultje
Date: Mon Nov  9 23:04:03 2009
New Revision: 20489

Log:
And on the sixth day, God gave us the <= operand, which makes the loop
"for (i = 1; i < num + 1; i++)" look like "for (i = 1; i <= num; i++)".
Programmers worldwide rejoiced and used the operand, e.g. in the thread
"[PATCH] remove ugliness in cel_filters.c", and He saw that it was good.

Modified:
   trunk/libavcodec/celp_filters.c

Modified: trunk/libavcodec/celp_filters.c
==============================================================================
--- trunk/libavcodec/celp_filters.c	Mon Nov  9 22:00:38 2009	(r20488)
+++ trunk/libavcodec/celp_filters.c	Mon Nov  9 23:04:03 2009	(r20489)
@@ -67,12 +67,9 @@ int ff_celp_lp_synthesis_filter(int16_t 
 {
     int i,n;
 
-    // Avoids a +1 in the inner loop.
-    filter_length++;
-
     for (n = 0; n < buffer_length; n++) {
         int sum = rounder;
-        for (i = 1; i < filter_length; i++)
+        for (i = 1; i <= filter_length; i++)
             sum -= filter_coeffs[i-1] * out[n-i];
 
         sum = (sum >> 12) + in[n];
@@ -96,12 +93,9 @@ void ff_celp_lp_synthesis_filterf(float 
 {
     int i,n;
 
-    // Avoids a +1 in the inner loop.
-    filter_length++;
-
     for (n = 0; n < buffer_length; n++) {
         out[n] = in[n];
-        for (i = 1; i < filter_length; i++)
+        for (i = 1; i <= filter_length; i++)
             out[n] -= filter_coeffs[i-1] * out[n-i];
     }
 }
@@ -114,12 +108,9 @@ void ff_celp_lp_zero_synthesis_filterf(f
 {
     int i,n;
 
-    // Avoids a +1 in the inner loop.
-    filter_length++;
-
     for (n = 0; n < buffer_length; n++) {
         out[n] = in[n];
-        for (i = 1; i < filter_length; i++)
+        for (i = 1; i <= filter_length; i++)
             out[n] += filter_coeffs[i-1] * in[n-i];
     }
 }



More information about the ffmpeg-cvslog mailing list