[FFmpeg-cvslog] r20620 - trunk/libavcodec/mpegaudio_tablegen.h

[Reimar Döffinger]

On Thu, Nov 26, 2009 at 11:34:58PM +0000, Carl Eugen Hoyos wrote:
> Diego Biurrun <diego <at> biurrun.de> writes:
> 
> > > @@ -27,7 +27,6 @@
> > >  #include <math.h>
> > > -#include "config.h"
> > >  
> > >  #define TABLE_4_3_SIZE (8191 + 16)*4
> > >  #if CONFIG_HARDCODED_TABLES
> 
> I may also not understand the issue correctly, but shouldn't this be
> #if defined(CONFIG_HARDCODED_TABLES) && CONFIG_HARDCODED_TABLES == 1
> (or however the preprocessor syntax looks like)?

That would be possible in principle, however it seems cleaner to just
define CONFIG_HARDCODED_TABLES together with anything else that is required
in the .c file - like this you will at least still get a warning if
it accidentally was not set at all.