[FFmpeg-cvslog] r19695 - trunk/libavcodec/twinvq.c

[Alexander Strasser]

Michael Niedermayer wrote:
> On Wed, Sep 02, 2009 at 11:19:58AM +0200, Diego Biurrun wrote:
> > On Fri, Aug 28, 2009 at 01:11:53PM +0200, Michael Niedermayer wrote:
> > > But dislike is an indication that there are problems, and
> > > i claim ommiting the spaces around * / is more readable. Also in
> > > mathematics with pencil and paper there are no spaces around * and / and
> > > actually * is not written at all its 
> > > A = 4ab + cd
> > > not 
> > > A = 4 * a * b + c * d
> > > And i think there is little question which is more readable and convenient
> > > 4ab is a more "strongly" bound unit than 4ab + cd so it makes sense to also
> > > use spaces differently
> > 
> > In math it is clear because numbers and letters are different
> > namespaces.  In C both are just parts of a string.
> 
> well, so its 
> A = 4*a*b + c*d
> vs.
> A = 4 * a * b + c * d
> 
> the first still is much more readable

  I agree that the first is much more readable. This was also sanctioned
in `The Practice of Programming' (a book written by Kernighan and Pike):

"We also removed some of the blanks: grouping the operands of
higher-precedence operators helps the reader to see the structure
more quickly."

[...]

  Alexander