[FFmpeg-cvslog] r22866 - trunk/libavcodec/raw.c

[Vitor Sessak]

Vitor Sessak wrote:
> stefano wrote:
>> Author: stefano
>> Date: Tue Apr 13 00:05:18 2010
>> New Revision: 22866
>>
>> Log:
>> Change ff_raw_pixelFormatTags RGB entries (RGB555, BGR555, RGB565,
>> BGR565, RGB565) to make them specify the tags for the LE variants
>> rather than for the native endian ones.
>>
>> Fix NUT compatibility.
>>
>> Modified:
>>    trunk/libavcodec/raw.c
>>
>> Modified: trunk/libavcodec/raw.c
>> ============================================================================== 
>>
>> --- trunk/libavcodec/raw.c    Mon Apr 12 23:49:04 2010    (r22865)
>> +++ trunk/libavcodec/raw.c    Tue Apr 13 00:05:18 2010    (r22866)
>> @@ -56,11 +56,11 @@ const PixelFormatTag ff_raw_pixelFormatT
>>      { PIX_FMT_UYVY422, MKTAG('A', 'V', 'u', 'p') },
>>      { PIX_FMT_UYVY422, MKTAG('V', 'D', 'T', 'Z') }, /* SoftLab-NSK 
>> VideoTizer */
>>      { PIX_FMT_GRAY8,   MKTAG('G', 'R', 'E', 'Y') },
>> -    { PIX_FMT_RGB555,  MKTAG('R', 'G', 'B', 15) },
>> -    { PIX_FMT_BGR555,  MKTAG('B', 'G', 'R', 15) },
>> -    { PIX_FMT_RGB565,  MKTAG('R', 'G', 'B', 16) },
>> -    { PIX_FMT_BGR565,  MKTAG('B', 'G', 'R', 16) },
>> -    { PIX_FMT_RGB565,  MKTAG( 3 ,  0 ,  0 ,  0 ) },
>> +    { PIX_FMT_RGB555LE, MKTAG('R', 'G', 'B', 15) },
>> +    { PIX_FMT_BGR555LE, MKTAG('B', 'G', 'R', 15) },
>> +    { PIX_FMT_RGB565LE, MKTAG('R', 'G', 'B', 16) },
>> +    { PIX_FMT_BGR565LE, MKTAG('B', 'G', 'R', 16) },
>> +    { PIX_FMT_RGB565LE, MKTAG( 3 ,  0 ,  0 ,  0) },
> 
> This seem to have broken MTV FATE test on bigendian machines. I think 
> the problem is that swscaler treats PIX_FMT_RGB565 as always been LE 
> while lavc treats it as been NE.

Scrap that. Actually the problem is that we have redundant pixfmts:
PIX_FMT_RGB565LE, PIX_FMT_BGR565BE
and
PIX_FMT_RGB565BE, PIX_FMT_BGR565LE

The problem is that removing them would break API. What do you think of 
  the attached patch (that fix make fate-mtv on PPC)?

-Vitor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bgr565.diff
Type: text/x-patch
Size: 4549 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100417/0e7edb1e/attachment.bin>