[FFmpeg-cvslog] r22974 - trunk/libavcodec/iff.c

[Michael Niedermayer]

On Tue, Apr 27, 2010 at 09:52:20AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Apr 26, 2010 at 8:28 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Tue, Apr 27, 2010 at 12:37:13AM +0200, rbultje wrote:
> >> Author: rbultje
> >> Date: Tue Apr 27 00:37:13 2010
> >> New Revision: 22974
> >>
> >> Log:
> >> Switch some ints to unsigned (they can only have positive values, this allows
> >> compiler to optimize some math from mul/div to shr/shl).
> 
> >> Also add a cast to
> >> uint32_t when calling decodeplane32().
> >
> > and why?
> 
> Silences a compiler warning.

->log


> 
> > and who approved this patch?
> 
> Mans and I.

and who reviewed the patch:
noone


> 
> [..]
> > never used in >> or /
> 
> Hmk, would you like me to revert these parts? I confess that I didn't
> check each individual one.

yes i would like you to revert all that you dont check and all that make
no difference

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100427/0ba12ade/attachment.pgp>