[FFmpeg-cvslog] r25920 - trunk/libavcodec/imgconvert.c

Stefano Sabatini stefano.sabatini-lala
Sun Dec 12 16:21:09 CET 2010


On date Sunday 2010-12-12 15:45:50 +0100, Reimar D?ffinger wrote:
> On Sun, Dec 12, 2010 at 03:42:01PM +0100, Vitor Sessak wrote:
> > On 12/08/2010 11:24 AM, stefano wrote:
> > >Author: stefano
> > >Date: Wed Dec  8 11:24:02 2010
> > >New Revision: 25920
> > >
> > >Log:
> > >Use av_image_alloc() in avpicture_alloc(), simplify.
> > 
> > Looks like this commit broke FATE on SunOS (see
> > http://fate.ffmpeg.org/sparc-solaris10-gcc-3.4).

FFALIGN(x, 0) -> 0

I wonder if we should add some check in av_image_alloc() for the case
where align <= 0.

The other bug is in av_malloc(), we should check size >= 0 (and return
NULL in that case).

> If you change av_malloc to return NULL if size == 0
> you should be able to reproduce this on all OS.



More information about the ffmpeg-cvslog mailing list