[FFmpeg-cvslog] r20814 - trunk/libavcodec/mpeg12.c

[Michael Niedermayer]

On Mon, Dec 06, 2010 at 03:32:53PM -0800, Baptiste Coudurier wrote:
> On 12/12/09 11:44 AM, michael wrote:
> > Author: michael
> > Date: Sat Dec 12 20:44:01 2009
> > New Revision: 20814
> > 
> > Log:
> > Be less picky on invalid invalid frame_pred_frame_dct values.
> > Fixed issue1615.
> > 
> > Modified:
> >    trunk/libavcodec/mpeg12.c
> > 
> > Modified: trunk/libavcodec/mpeg12.c
> > ==============================================================================
> > --- trunk/libavcodec/mpeg12.c	Sat Dec 12 20:15:56 2009	(r20813)
> > +++ trunk/libavcodec/mpeg12.c	Sat Dec 12 20:44:01 2009	(r20814)
> > @@ -1557,7 +1557,7 @@ static void mpeg_decode_picture_coding_e
> >          s->picture_structure= PICT_FRAME;
> >      }
> >  
> > -    if(s->progressive_frame && !s->frame_pred_frame_dct){
> > +    if(s->progressive_sequence && !s->frame_pred_frame_dct){
> >          av_log(s->avctx, AV_LOG_ERROR, "invalid frame_pred_frame_dct\n");
> >          s->frame_pred_frame_dct= 1;
> >      }
> 
> This commit and 20654 are causing issues, see #2405.
> 
> Since frame_pred_frame_dct is affecting the bitstream syntax, overriding
> it seems unstable to me :/

:/
Not overriding it makes the state inconsistent, that is interlaced stuff in
progressive_sequences.

does this file decode correctly without the frame_pred_frame_dct overriding?
does it contain actual non progressive MBs ?
is it free of issues in valgrind if the overridiing is removed and its fuzzed?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20101215/49b1a5e6/attachment.pgp>