[FFmpeg-cvslog] r26016 - trunk/libavformat/rtpdec.c

[Martin Storsjö]

On Wed, 15 Dec 2010, lu_zero wrote:

> Author: lu_zero
> Date: Wed Dec 15 18:16:37 2010
> New Revision: 26016
> 
> Log:
> Reinstate default time_base for rtp streams
> 
> The generic default is 0/0 and that obviously triggers once the value is used.

No, the generic default is 90 kHz, set in av_new_stream. In which case are 
you getting a 0/0 value? That sounds like the default has been overwritten 
by a 0 somewhere.

> Modified:
>    trunk/libavformat/rtpdec.c
> 
> Modified: trunk/libavformat/rtpdec.c
> ==============================================================================
> --- trunk/libavformat/rtpdec.c	Wed Dec 15 01:22:47 2010	(r26015)
> +++ trunk/libavformat/rtpdec.c	Wed Dec 15 18:16:37 2010	(r26016)
> @@ -393,6 +393,7 @@ RTPDemuxContext *rtp_parse_open(AVFormat
>              return NULL;
>          }
>      } else {
> +        av_set_pts_info(st, 32, 1, 90000);
>          switch(st->codec->codec_id) {
>          case CODEC_ID_MPEG1VIDEO:
>          case CODEC_ID_MPEG2VIDEO:

Setting the default here is broken, it overwrites whatever time_base the 
SDP parsing set before. If we need an explicit default, it should be next 
to the call to av_new_stream in rtsp.c.

But as I said - av_new_stream already sets the default value, so this 
"fix" doesn't fix what you think it does, and instead forces the time base 
to 90 kHz for every single stream.

// Martin