[FFmpeg-cvslog] r23647 - in trunk: Changelog libavcodec/Makefile libavcodec/aacdec.c libavcodec/aacsbr.c libavcodec/avcodec.h libavcodec/mpeg4audio.c libavcodec/ps.c libavcodec/ps.h libavcodec/ps_tablegen.c libavc...

[Reimar Döffinger]

On Sun, Jun 20, 2010 at 04:06:06AM +0200, Michael Niedermayer wrote:
> > +#if CONFIG_HARDCODED_TABLES
> > +#define ps_tableinit()
> > +#include "libavcodec/ps_tables.h"
> > +#else
> > +#include "../libavutil/common.h"
> > +#ifndef M_SQRT1_2
> > +#define M_SQRT1_2      0.70710678118654752440  /* 1/sqrt(2) */
> > +#endif
> > +#ifndef M_PI
> > +#define M_PI           3.14159265358979323846  /* pi */
> > +#endif
> > +#ifndef M_SQRT2
> > +#define M_SQRT2        1.41421356237309504880  /* sqrt(2) */
> 
> these constants should be already in some libavutil header

Yes, but that header can't be used for host compilation.
What do people think about splitting those out into a
mathconsts.h or so?