[FFmpeg-cvslog] r23670 - trunk/libavcodec/ps.c

Måns Rullgård mans
Mon Jun 21 18:57:53 CEST 2010


Alex Converse <alex.converse at gmail.com> writes:

> On Mon, Jun 21, 2010 at 5:22 AM, Aurelien Jacobs <aurel at gnuage.org> wrote:
>> On Mon, Jun 21, 2010 at 12:13:44AM +0200, alexc wrote:
>>> Author: alexc
>>> Date: Mon Jun 21 00:13:43 2010
>>> New Revision: 23670
>>>
>>> Log:
>>> psdec: IPD/OPD reset is no longer needed by the context initializer.
>>>
>>> Modified:
>>> ? ?trunk/libavcodec/ps.c
>>>
>>> Modified: trunk/libavcodec/ps.c
>>> ==============================================================================
>>> --- trunk/libavcodec/ps.c ? ? Mon Jun 21 00:08:33 2010 ? ? ? ?(r23669)
>>> +++ trunk/libavcodec/ps.c ? ? Mon Jun 21 00:13:43 2010 ? ? ? ?(r23670)
>>> @@ -1034,5 +1034,4 @@ av_cold void ff_ps_init(void) {
>>>
>>> ?av_cold void ff_ps_ctx_init(PSContext *ps)
>>> ?{
>>> - ? ?ipdopd_reset(ps->ipd_hist, ps->opd_hist);
>>> ?}
>>
>> Unless you plan to use it for something else, this function could be
>> removed. See attached patch.
>>
>
> If it really bothers people it can be removed. I kind of like keeping
> it there incase any context variables need to be initialized in the
> future. It may wind up in use again after filterbank optimizations.

Let's leave it until the code settles then.  If it's still empty after
optimisations are done, we should remove it.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-cvslog mailing list