[FFmpeg-cvslog] r25278 - in trunk: ffmpeg.c libavutil/Makefile libavutil/assert.h libavutil/avutil.h libavutil/rational.c

[Ronald S. Bultje]

Hi,

On Sep 30, 2010, at 9:30 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Sep 30, 2010 at 07:37:36PM -0400, Ronald S. Bultje wrote:
>> (Review would've been nice - what problem does this solve exactly?)
> 
> that of our code being filled with #undef NDEBUG hacks
> 
> the problem of asserts() that are in speed critical code (aka enabling them
> slows things down significantly) and asserts that are in speed uncritical paths
> being inseperable.
> The thing is a devel wants to enable the ones that have no speed effect most of
> the time but theres a good reason not to enable the asserts that slow the code
> down
> 
> This was discussed previously, no volunteers came forward to work on it.
> I knew mans would attack me when i commit no matter what i commit, i
> was a bit surprised to see your reply though.

I'm not necessarily attacking... But I need to know how (and how not) to use this, or I'll keep complaining about already-solved problems.

When do I use av_assert0/1/2()? What's the difference? How do I enable each separately or all together? I need a howto. ;-).

Ronald