[FFmpeg-cvslog] In retry_transfer_wrapper, do not check url_interrupt_cb,
Martin Storsjö
martin
Fri Mar 4 09:18:10 CET 2011
On Fri, 4 Mar 2011, Nicolas George wrote:
> Le tridi 13 vent?se, an CCXIX, Baptiste Coudurier a ?crit?:
> > Can you please check ? Many users reported the problem,
>
> Do you have a reference? I did not notice them.
>
> > ffmpeg was
> > basically broken.
>
> That is strange, the test suite passed ok when this change was committed.
Sorry, I can't work on this at the time, I'm going away over the weekend.
Nicolas, it won't break normal full runs. But if you're transcoding a long
file and abort it halfway by pressing 'q', it should still write a clean
file trailer. (Some formats are more readable if totally aborted, some
less. Try writing mp4/mov for instance.) I guess url_interrupt_cb() didn't
interrupt the raw file protocols before, so we should at least move the
url_interrupt_cb() check a bit down so it won't hurt those ones, but still
be checked for the network ones when they return EAGAIN.
// Martin
More information about the ffmpeg-cvslog
mailing list