[FFmpeg-cvslog] lavf: avoid integer overflow when estimating bitrate
Anton Khirnov
git at videolan.org
Tue Sep 3 14:50:47 CEST 2013
ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Sat Aug 24 21:30:46 2013 +0200| [df33a58e5311ee9a64a573889b883a80e981af7b] | committer: Anton Khirnov
lavf: avoid integer overflow when estimating bitrate
Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable at libav.org
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=df33a58e5311ee9a64a573889b883a80e981af7b
---
libavformat/utils.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index eb89f43..3644bcd 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -1757,8 +1757,13 @@ static void estimate_timings_from_bit_rate(AVFormatContext *ic)
int bit_rate = 0;
for(i=0;i<ic->nb_streams;i++) {
st = ic->streams[i];
- if (st->codec->bit_rate > 0)
- bit_rate += st->codec->bit_rate;
+ if (st->codec->bit_rate > 0) {
+ if (INT_MAX - st->codec->bit_rate > bit_rate) {
+ bit_rate = 0;
+ break;
+ }
+ bit_rate += st->codec->bit_rate;
+ }
}
ic->bit_rate = bit_rate;
}
More information about the ffmpeg-cvslog
mailing list