[FFmpeg-cvslog] avformat/httpauth: add comment about "" and algorithm
Michael Niedermayer
git at videolan.org
Mon Mar 3 17:11:47 CET 2014
ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Mon Mar 3 17:04:57 2014 +0100| [ab5d46df1656a23cb75b005a3d7730e189e38c4d] | committer: Michael Niedermayer
avformat/httpauth: add comment about "" and algorithm
Suggested-by: ubitux
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ab5d46df1656a23cb75b005a3d7730e189e38c4d
---
libavformat/httpauth.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/httpauth.c b/libavformat/httpauth.c
index 3f90975..dbe3eff 100644
--- a/libavformat/httpauth.c
+++ b/libavformat/httpauth.c
@@ -224,8 +224,11 @@ static char *make_digest_auth(HTTPAuthState *state, const char *username,
av_strlcatf(authstr, len, ",nonce=\"%s\"", digest->nonce);
av_strlcatf(authstr, len, ",uri=\"%s\"", uri);
av_strlcatf(authstr, len, ",response=\"%s\"", response);
+
+ // we are violating the RFC and use "" because all others seem to do that too.
if (digest->algorithm[0])
av_strlcatf(authstr, len, ",algorithm=\"%s\"", digest->algorithm);
+
if (digest->opaque[0])
av_strlcatf(authstr, len, ",opaque=\"%s\"", digest->opaque);
if (digest->qop[0]) {
More information about the ffmpeg-cvslog
mailing list