[FFmpeg-cvslog] lavf: Don't try to update files atomically with renames on windows

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Nov 25 08:59:36 CET 2014


On 25.11.2014, at 02:48, git at videolan.org (Martin Storsjö) wrote:
> ffmpeg | branch: master | Martin Storsjö <martin at martin.st> | Tue Nov 18 14:06:19 2014 +0200| [b9d08c77a44390b0848c06f20bc0e9e951ba6a3c] | committer: Martin Storsjö
> 
> lavf: Don't try to update files atomically with renames on windows
> 
> On windows, rename(2) will fail if the target file exists. On
> unix this trick is used to make sure that people reading the file
> either will get the full previous file, or the full new version
> of the file, but no intermediate version.

I don't think this is the right solution, I think rename should be mapped to MoveFileEx with the appropriate flags set, so it behaves like POSIX.
(there are many flags, one is to allow overwriting, but there are others to indicate whether it may cross file systems etc.)


More information about the ffmpeg-cvslog mailing list