[FFmpeg-cvslog] aacenc_ltp: fix out of bounds memory access

Rostislav Pehlivanov git at videolan.org
Fri Dec 4 00:14:12 CET 2015


ffmpeg | branch: master | Rostislav Pehlivanov <atomnuker at gmail.com> | Thu Dec  3 23:12:37 2015 +0000| [ed08cbd7b172a1dba74230527ef761aafaf2fcce] | committer: Rostislav Pehlivanov

aacenc_ltp: fix out of bounds memory access

Discovered by Coverity.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ed08cbd7b172a1dba74230527ef761aafaf2fcce
---

 libavcodec/aacenc_ltp.c |    2 +-
 tests/fate/aac.mak      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/aacenc_ltp.c b/libavcodec/aacenc_ltp.c
index e19f3cc..1917ee9 100644
--- a/libavcodec/aacenc_ltp.c
+++ b/libavcodec/aacenc_ltp.c
@@ -167,7 +167,7 @@ void ff_aac_search_for_ltp(AACEncContext *s, SingleChannelElement *sce,
 
     if (sce->ics.window_sequence[0] == EIGHT_SHORT_SEQUENCE) {
         if (sce->ics.ltp.lag) {
-            memset(&sce->lcoeffs[0], 0.0f, 3072*sizeof(sce->lcoeffs[0]));
+            memset(&sce->ltp_state[0], 0, 3072*sizeof(sce->ltp_state[0]));
             memset(&sce->ics.ltp, 0, sizeof(LongTermPrediction));
         }
         return;
diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
index 7a6c734..09777af 100644
--- a/tests/fate/aac.mak
+++ b/tests/fate/aac.mak
@@ -209,7 +209,7 @@ fate-aac-ltp-encode: CMD = enc_dec_pcm adts wav s16le $(TARGET_SAMPLES)/audio-re
 fate-aac-ltp-encode: CMP = stddev
 fate-aac-ltp-encode: REF = $(SAMPLES)/audio-reference/luckynight_2ch_44kHz_s16.wav
 fate-aac-ltp-encode: CMP_SHIFT = -4096
-fate-aac-ltp-encode: CMP_TARGET = 1284
+fate-aac-ltp-encode: CMP_TARGET = 1273
 fate-aac-ltp-encode: SIZE_TOLERANCE = 3560
 fate-aac-ltp-encode: FUZZ = 17
 



More information about the ffmpeg-cvslog mailing list