[FFmpeg-cvslog] avdevice/decklink_enc: do not reference this after freeing it

Marton Balint git at videolan.org
Tue Dec 27 02:26:08 EET 2016


ffmpeg | branch: master | Marton Balint <cus at passwd.hu> | Sat Dec 10 13:57:01 2016 +0100| [a7946c8964691a8cac8e8c479d61c9b068d9d76e] | committer: Marton Balint

avdevice/decklink_enc: do not reference this after freeing it

Fixes Coverity CID 1396863.

Signed-off-by: Marton Balint <cus at passwd.hu>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a7946c8964691a8cac8e8c479d61c9b068d9d76e
---

 libavdevice/decklink_enc.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp
index dc4a24b..ad00224 100644
--- a/libavdevice/decklink_enc.cpp
+++ b/libavdevice/decklink_enc.cpp
@@ -55,7 +55,7 @@ public:
 
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(REFIID iid, LPVOID *ppv) { return E_NOINTERFACE; }
     virtual ULONG   STDMETHODCALLTYPE AddRef(void)                            { return ++_refs; }
-    virtual ULONG   STDMETHODCALLTYPE Release(void)                           { if (!--_refs) delete this; return _refs; }
+    virtual ULONG   STDMETHODCALLTYPE Release(void)                           { if (!--_refs) {delete this; return 0;} return _refs; }
 
     struct decklink_ctx *_ctx;
     AVFrame *_avframe;



More information about the ffmpeg-cvslog mailing list