[FFmpeg-cvslog] avformat/mov: Break out early if chunk_count is 0 in mov_build_index()

Michael Niedermayer git at videolan.org
Sat Jun 16 01:31:55 EEST 2018


ffmpeg | branch: release/4.0 | Michael Niedermayer <michael at niedermayer.cc> | Tue May 15 17:06:59 2018 +0200| [1d01a3b34c924998da310c4776af36047d1b7fde] | committer: Michael Niedermayer

avformat/mov: Break out early if chunk_count is 0 in mov_build_index()

Without this some operations might overflow (undefined behavior)
even though the index adding loop would never execute

No testcase known

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit 56e76bd0579cc7f7b28860885d9e569a39daf41b)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=1d01a3b34c924998da310c4776af36047d1b7fde
---

 libavformat/mov.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 0667ba3ded..da0b1942b9 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -3899,6 +3899,9 @@ static void mov_build_index(MOVContext *mov, AVStream *st)
     } else {
         unsigned chunk_samples, total = 0;
 
+        if (!sc->chunk_count)
+            return;
+
         // compute total chunk count
         for (i = 0; i < sc->stsc_count; i++) {
             unsigned count, chunk_count;



More information about the ffmpeg-cvslog mailing list