[FFmpeg-cvslog] avformat/matroskaenc: fix leak on error

Tristan Matthews git at videolan.org
Tue Apr 9 16:50:05 EEST 2019


ffmpeg | branch: master | Tristan Matthews <tmatth at videolan.org> | Thu Apr  4 12:56:26 2019 -0400| [1ec777dcdd03b43d3d694c3b4532dccea0b419f0] | committer: James Almer

avformat/matroskaenc: fix leak on error

Signed-off-by: James Almer <jamrial at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=1ec777dcdd03b43d3d694c3b4532dccea0b419f0
---

 libavformat/matroskaenc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 06f3aeb46d..1c98c0dceb 100644
--- a/libavformat/matroskaenc.c
+++ b/libavformat/matroskaenc.c
@@ -694,8 +694,10 @@ static int put_flac_codecpriv(AVFormatContext *s,
         av_dict_set(&dict, "WAVEFORMATEXTENSIBLE_CHANNEL_MASK", buf, 0);
 
         len = ff_vorbiscomment_length(dict, vendor, NULL, 0);
-        if (len >= ((1<<24) - 4))
+        if (len >= ((1<<24) - 4)) {
+            av_dict_free(&dict);
             return AVERROR(EINVAL);
+        }
 
         data = av_malloc(len + 4);
         if (!data) {



More information about the ffmpeg-cvslog mailing list