[FFmpeg-cvslog] avcodec/tiff: Set FF_CODEC_CAP_INIT_CLEANUP
Michael Niedermayer
git at videolan.org
Thu Oct 3 22:34:40 EEST 2019
ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Wed Oct 2 21:14:17 2019 +0200| [379e5d29d50ef957a65cfd536bc8c0713755fb77] | committer: Michael Niedermayer
avcodec/tiff: Set FF_CODEC_CAP_INIT_CLEANUP
Fixes: memleaks
Fixes: 17813/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-5145600206569472
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda at gmail.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=379e5d29d50ef957a65cfd536bc8c0713755fb77
---
libavcodec/tiff.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
index 9f24796a88..f537e99b5a 100644
--- a/libavcodec/tiff.c
+++ b/libavcodec/tiff.c
@@ -2090,8 +2090,6 @@ static av_cold int tiff_init(AVCodecContext *avctx)
s->avctx_mjpeg->idct_algo = avctx->idct_algo;
ret = ff_codec_open2_recursive(s->avctx_mjpeg, codec, NULL);
if (ret < 0) {
- av_frame_free(&s->jpgframe);
- avcodec_free_context(&s->avctx_mjpeg);
return ret;
}
@@ -2142,5 +2140,6 @@ AVCodec ff_tiff_decoder = {
.decode = decode_frame,
.init_thread_copy = ONLY_IF_THREADS_ENABLED(tiff_init),
.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_FRAME_THREADS,
+ .caps_internal = FF_CODEC_CAP_INIT_CLEANUP,
.priv_class = &tiff_decoder_class,
};
More information about the ffmpeg-cvslog
mailing list