[FFmpeg-cvslog] avfilter/f_ebur128: Don't allocate outpad names
Andreas Rheinhardt
git at videolan.org
Thu Aug 27 00:54:44 EEST 2020
ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Sat Aug 22 04:13:28 2020 +0200| [9b34600bd2d72a790f250aa539cf29176fec6ae7] | committer: Andreas Rheinhardt
avfilter/f_ebur128: Don't allocate outpad names
These names are mostly the same, so not using duplicates saves
allocations, checks for the allocations as well as frees.
Reviewed-by: Paul B Mahol <onemda at gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b34600bd2d72a790f250aa539cf29176fec6ae7
---
libavfilter/f_ebur128.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c
index 31b75ab097..5ae3dc25b8 100644
--- a/libavfilter/f_ebur128.c
+++ b/libavfilter/f_ebur128.c
@@ -527,30 +527,22 @@ static av_cold int init(AVFilterContext *ctx)
/* insert output pads */
if (ebur128->do_video) {
pad = (AVFilterPad){
- .name = av_strdup("out0"),
+ .name = "out0",
.type = AVMEDIA_TYPE_VIDEO,
.config_props = config_video_output,
};
- if (!pad.name)
- return AVERROR(ENOMEM);
ret = ff_insert_outpad(ctx, 0, &pad);
- if (ret < 0) {
- av_freep(&pad.name);
+ if (ret < 0)
return ret;
- }
}
pad = (AVFilterPad){
- .name = av_asprintf("out%d", ebur128->do_video),
+ .name = ebur128->do_video ? "out1" : "out0",
.type = AVMEDIA_TYPE_AUDIO,
.config_props = config_audio_output,
};
- if (!pad.name)
- return AVERROR(ENOMEM);
ret = ff_insert_outpad(ctx, ebur128->do_video, &pad);
- if (ret < 0) {
- av_freep(&pad.name);
+ if (ret < 0)
return ret;
- }
/* summary */
av_log(ctx, AV_LOG_VERBOSE, "EBU +%d scale\n", ebur128->meter);
@@ -990,8 +982,6 @@ static av_cold void uninit(AVFilterContext *ctx)
av_freep(&ebur128->i400.cache[i]);
av_freep(&ebur128->i3000.cache[i]);
}
- for (i = 0; i < ctx->nb_outputs; i++)
- av_freep(&ctx->output_pads[i].name);
av_frame_free(&ebur128->outpicref);
#if CONFIG_SWRESAMPLE
av_freep(&ebur128->swr_buf);
More information about the ffmpeg-cvslog
mailing list