[FFmpeg-cvslog] avformat/httpauth: do not decode plus sign to space in credentials

Marton Balint git at videolan.org
Sat Feb 15 20:27:02 EET 2020


ffmpeg | branch: master | Marton Balint <cus at passwd.hu> | Tue Feb  4 23:46:23 2020 +0100| [3004ef1b1b1bcd6bec4ad3509662ab1a4b644149] | committer: Marton Balint

avformat/httpauth: do not decode plus sign to space in credentials

Signed-off-by: Marton Balint <cus at passwd.hu>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3004ef1b1b1bcd6bec4ad3509662ab1a4b644149
---

 libavformat/httpauth.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavformat/httpauth.c b/libavformat/httpauth.c
index 54d0322c6a..4f79c78edc 100644
--- a/libavformat/httpauth.c
+++ b/libavformat/httpauth.c
@@ -255,7 +255,7 @@ char *ff_http_auth_create_response(HTTPAuthState *state, const char *auth,
 
     if (state->auth_type == HTTP_AUTH_BASIC) {
         int auth_b64_len, len;
-        char *ptr, *decoded_auth = ff_urldecode(auth, 1);
+        char *ptr, *decoded_auth = ff_urldecode(auth, 0);
 
         if (!decoded_auth)
             return NULL;
@@ -275,7 +275,7 @@ char *ff_http_auth_create_response(HTTPAuthState *state, const char *auth,
         av_strlcat(ptr, "\r\n", len - (ptr - authstr));
         av_free(decoded_auth);
     } else if (state->auth_type == HTTP_AUTH_DIGEST) {
-        char *username = ff_urldecode(auth, 1), *password;
+        char *username = ff_urldecode(auth, 0), *password;
 
         if (!username)
             return NULL;



More information about the ffmpeg-cvslog mailing list