[FFmpeg-cvslog] avformat/utils: Don't trigger errors for multiple id3 tags.
Dale Curtis
git at videolan.org
Sat Feb 22 22:21:47 EET 2020
ffmpeg | branch: master | Dale Curtis <dalecurtis at chromium.org> | Fri Feb 21 12:53:30 2020 -0800| [a0faf0db4f9f85ce2b8e00660c4fd884a347ca19] | committer: Michael Niedermayer
avformat/utils: Don't trigger errors for multiple id3 tags.
Such errors may make sense for specific formats, but general parsing
logic shouldn't be treating these as errors regardless of the error
recognition mode.
Fixes loading of the following wave when using -err_detect explode:
https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/webaudio/resources/4ch-440.wav
Signed-off-by: Dale Curtis <dalecurtis at chromium.org>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a0faf0db4f9f85ce2b8e00660c4fd884a347ca19
---
libavformat/utils.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index 123d67800b..cb15f6a4b3 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -635,15 +635,8 @@ FF_ENABLE_DEPRECATION_WARNINGS
s->metadata = s->internal->id3v2_meta;
s->internal->id3v2_meta = NULL;
} else if (s->internal->id3v2_meta) {
- int level = AV_LOG_WARNING;
- if (s->error_recognition & AV_EF_COMPLIANT)
- level = AV_LOG_ERROR;
- av_log(s, level, "Discarding ID3 tags because more suitable tags were found.\n");
+ av_log(s, AV_LOG_WARNING, "Discarding ID3 tags because more suitable tags were found.\n");
av_dict_free(&s->internal->id3v2_meta);
- if (s->error_recognition & AV_EF_EXPLODE) {
- ret = AVERROR_INVALIDDATA;
- goto close;
- }
}
if (id3v2_extra_meta) {
More information about the ffmpeg-cvslog
mailing list