[FFmpeg-cvslog] avformat/sccdec: Fix memleak upon read header failure
Andreas Rheinhardt
git at videolan.org
Fri Jul 3 16:09:24 EEST 2020
ffmpeg | branch: release/3.3 | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Sun Jun 14 03:22:32 2020 +0200| [ba1f99c86a7b368bf5d99ef33df5b9b5ea52d295] | committer: Andreas Rheinhardt
avformat/sccdec: Fix memleak upon read header failure
The already parsed subtitles (contained in an FFDemuxSubtitlesQueue)
would leak if an error happened upon reading a subsequent subtitle.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
(cherry picked from commit f3c63e67bb00fa7d96595203d01a576df651e275)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ba1f99c86a7b368bf5d99ef33df5b9b5ea52d295
---
libavformat/sccdec.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c
index 89d21b9c1f..371d2d9d13 100644
--- a/libavformat/sccdec.c
+++ b/libavformat/sccdec.c
@@ -132,7 +132,7 @@ static int scc_read_header(AVFormatContext *s)
sub = ff_subtitles_queue_insert(&scc->q, out, i, 0);
if (!sub)
- return AVERROR(ENOMEM);
+ goto fail;
sub->pos = pos;
sub->pts = ts_start;
@@ -144,6 +144,9 @@ static int scc_read_header(AVFormatContext *s)
ff_subtitles_queue_finalize(s, &scc->q);
return ret;
+fail:
+ ff_subtitles_queue_clean(&scc->q);
+ return AVERROR(ENOMEM);
}
static int scc_read_packet(AVFormatContext *s, AVPacket *pkt)
More information about the ffmpeg-cvslog
mailing list