[FFmpeg-cvslog] avcodec/h264_slice: use av_buffer_replace() to simplify code
James Almer
git at videolan.org
Mon Oct 5 17:22:49 EEST 2020
ffmpeg | branch: master | James Almer <jamrial at gmail.com> | Mon Sep 28 11:25:41 2020 -0300| [0b6541368d60fc52b16504a2be753635eceac3df] | committer: James Almer
avcodec/h264_slice: use av_buffer_replace() to simplify code
Based on eff289ce9f030f023e218ee7ce354d4f0e035b6d.
Reviewed-by: Anton Khirnov <anton at khirnov.net>
Signed-off-by: James Almer <jamrial at gmail.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=0b6541368d60fc52b16504a2be753635eceac3df
---
libavcodec/h264_slice.c | 34 ++++++++++++----------------------
1 file changed, 12 insertions(+), 22 deletions(-)
diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
index db7302a8b5..74575bccd4 100644
--- a/libavcodec/h264_slice.c
+++ b/libavcodec/h264_slice.c
@@ -325,29 +325,22 @@ int ff_h264_update_thread_context(AVCodecContext *dst,
// SPS/PPS
for (i = 0; i < FF_ARRAY_ELEMS(h->ps.sps_list); i++) {
- av_buffer_unref(&h->ps.sps_list[i]);
- if (h1->ps.sps_list[i]) {
- h->ps.sps_list[i] = av_buffer_ref(h1->ps.sps_list[i]);
- if (!h->ps.sps_list[i])
- return AVERROR(ENOMEM);
- }
+ ret = av_buffer_replace(&h->ps.sps_list[i], h1->ps.sps_list[i]);
+ if (ret < 0)
+ return ret;
}
for (i = 0; i < FF_ARRAY_ELEMS(h->ps.pps_list); i++) {
- av_buffer_unref(&h->ps.pps_list[i]);
- if (h1->ps.pps_list[i]) {
- h->ps.pps_list[i] = av_buffer_ref(h1->ps.pps_list[i]);
- if (!h->ps.pps_list[i])
- return AVERROR(ENOMEM);
- }
+ ret = av_buffer_replace(&h->ps.pps_list[i], h1->ps.pps_list[i]);
+ if (ret < 0)
+ return ret;
}
- av_buffer_unref(&h->ps.pps_ref);
+ ret = av_buffer_replace(&h->ps.pps_ref, h1->ps.pps_ref);
+ if (ret < 0)
+ return ret;
h->ps.pps = NULL;
h->ps.sps = NULL;
if (h1->ps.pps_ref) {
- h->ps.pps_ref = av_buffer_ref(h1->ps.pps_ref);
- if (!h->ps.pps_ref)
- return AVERROR(ENOMEM);
h->ps.pps = (const PPS*)h->ps.pps_ref->data;
h->ps.sps = h->ps.pps->sps;
}
@@ -432,12 +425,9 @@ int ff_h264_update_thread_context(AVCodecContext *dst,
h->frame_recovered = h1->frame_recovered;
- av_buffer_unref(&h->sei.a53_caption.buf_ref);
- if (h1->sei.a53_caption.buf_ref) {
- h->sei.a53_caption.buf_ref = av_buffer_ref(h1->sei.a53_caption.buf_ref);
- if (!h->sei.a53_caption.buf_ref)
- return AVERROR(ENOMEM);
- }
+ ret = av_buffer_replace(&h->sei.a53_caption.buf_ref, h1->sei.a53_caption.buf_ref);
+ if (ret < 0)
+ return ret;
for (i = 0; i < h->sei.unregistered.nb_buf_ref; i++)
av_buffer_unref(&h->sei.unregistered.buf_ref[i]);
More information about the ffmpeg-cvslog
mailing list