[FFmpeg-cvslog] avfilter/af_headphone: Check for the existence of samples
Andreas Rheinhardt
git at videolan.org
Wed Sep 9 15:59:39 EEST 2020
ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Fri Aug 28 10:37:46 2020 +0200| [dfd46e2d160afcb7e453d0e2394a6978cb447712] | committer: Andreas Rheinhardt
avfilter/af_headphone: Check for the existence of samples
Not providing any samples makes no sense at all. And if no samples
were provided for one of the HRIR streams, one would either run into
an av_assert1 in ff_inlink_consume_samples() or into a segfault in
take_samples() in avfilter.c.
Reviewed-by: Paul B Mahol <onemda at gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=dfd46e2d160afcb7e453d0e2394a6978cb447712
---
libavfilter/af_headphone.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c
index 1024ff57b1..f488e0e28d 100644
--- a/libavfilter/af_headphone.c
+++ b/libavfilter/af_headphone.c
@@ -631,8 +631,14 @@ static int activate(AVFilterContext *ctx)
if ((ret = check_ir(ctx->inputs[i], i)) < 0)
return ret;
- if (ff_outlink_get_status(ctx->inputs[i]) == AVERROR_EOF)
+ if (ff_outlink_get_status(ctx->inputs[i]) == AVERROR_EOF) {
+ if (!ff_inlink_queued_samples(ctx->inputs[i])) {
+ av_log(ctx, AV_LOG_ERROR, "No samples provided for "
+ "HRIR stream %d.\n", i - 1);
+ return AVERROR_INVALIDDATA;
+ }
s->in[i].eof = 1;
+ }
}
for (i = 1; i < s->nb_inputs; i++) {
More information about the ffmpeg-cvslog
mailing list