[FFmpeg-cvslog] avformat/wtvdec: Check size in SBE2_STREAM_DESC_EVENT / stream2_guid
Michael Niedermayer
git at videolan.org
Thu Apr 1 12:49:47 EEST 2021
ffmpeg | branch: release/4.4 | Michael Niedermayer <michael at niedermayer.cc> | Thu Mar 4 00:30:45 2021 +0100| [9179ab9227d63b9fe5be06940be11672aec17517] | committer: Michael Niedermayer
avformat/wtvdec: Check size in SBE2_STREAM_DESC_EVENT / stream2_guid
Fixes: signed integer overflow: 539033600 - -1910497124 cannot be represented in type 'int'
Fixes: 30928/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-5922630966312960
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit 1f74661543c0c336e88846f90608fda7bd12deac)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9179ab9227d63b9fe5be06940be11672aec17517
---
libavformat/wtvdec.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c
index 7def9d2348..4b3b7fb407 100644
--- a/libavformat/wtvdec.c
+++ b/libavformat/wtvdec.c
@@ -817,6 +817,8 @@ static int parse_chunks(AVFormatContext *s, int mode, int64_t seekts, int *len_p
avio_skip(pb, 12);
ff_get_guid(pb, &formattype);
size = avio_rl32(pb);
+ if (size < 0 || size > INT_MAX - 92)
+ return AVERROR_INVALIDDATA;
parse_media_type(s, 0, sid, mediatype, subtype, formattype, size);
consumed += 92 + size;
}
@@ -831,6 +833,8 @@ static int parse_chunks(AVFormatContext *s, int mode, int64_t seekts, int *len_p
avio_skip(pb, 12);
ff_get_guid(pb, &formattype);
size = avio_rl32(pb);
+ if (size < 0 || size > INT_MAX - 76)
+ return AVERROR_INVALIDDATA;
parse_media_type(s, s->streams[stream_index], sid, mediatype, subtype, formattype, size);
consumed += 76 + size;
}
More information about the ffmpeg-cvslog
mailing list