[FFmpeg-cvslog] avformat/http: prevent truncation of sanitized_path

James Almer git at videolan.org
Thu Nov 25 17:07:00 EET 2021


ffmpeg | branch: master | James Almer <jamrial at gmail.com> | Wed Jun  9 17:01:02 2021 -0300| [b46817d9c3fe620ba02f2b3144444c431c6ba552] | committer: James Almer

avformat/http: prevent truncation of sanitized_path

path1 and sanitized_path are both MAX_URL_SIZE bytes long, yet the latter is
copied from the former with the addition of one extra character.

Should fix a -Wformat-truncation warning.

Signed-off-by: James Almer <jamrial at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b46817d9c3fe620ba02f2b3144444c431c6ba552
---

 libavformat/http.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/http.c b/libavformat/http.c
index fdfbc69da1..91650be47a 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -194,7 +194,7 @@ static int http_open_cnx_internal(URLContext *h, AVDictionary **options)
     char *hashmark;
     char hostname[1024], hoststr[1024], proto[10];
     char auth[1024], proxyauth[1024] = "";
-    char path1[MAX_URL_SIZE], sanitized_path[MAX_URL_SIZE];
+    char path1[MAX_URL_SIZE], sanitized_path[MAX_URL_SIZE + 1];
     char buf[1024], urlbuf[MAX_URL_SIZE];
     int port, use_proxy, err, location_changed = 0;
     HTTPContext *s = h->priv_data;



More information about the ffmpeg-cvslog mailing list