[FFmpeg-cvslog] avformat/sbgdec: Check for negative duration or un-representable end pts

Michael Niedermayer git at videolan.org
Mon Oct 9 00:00:37 EEST 2023


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Sun Oct  1 00:30:39 2023 +0200| [9b00b5734d9868971cb6e6cda0f3b8eeed93be9e] | committer: Michael Niedermayer

avformat/sbgdec: Check for negative duration or un-representable end pts

Fixes: signed integer overflow: 9230955872951340 - -9223372036854775808 cannot be represented in type 'long'
Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6330481893572608

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Nicolas George <george at nsup.org>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b00b5734d9868971cb6e6cda0f3b8eeed93be9e
---

 libavformat/sbgdec.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/libavformat/sbgdec.c b/libavformat/sbgdec.c
index 73b5be9007..b2662ea418 100644
--- a/libavformat/sbgdec.c
+++ b/libavformat/sbgdec.c
@@ -1447,6 +1447,13 @@ static av_cold int sbg_read_header(AVFormatContext *avf)
     st->duration      = script.end_ts == AV_NOPTS_VALUE ? AV_NOPTS_VALUE :
                         av_rescale(script.end_ts - script.start_ts,
                                    sbg->sample_rate, AV_TIME_BASE);
+
+    if (st->duration != AV_NOPTS_VALUE && (
+        st->duration < 0 || st->start_time > INT64_MAX - st->duration)) {
+        r = AVERROR_INVALIDDATA;
+        goto fail;
+    }
+
     sti->cur_dts      = st->start_time;
     r = encode_intervals(&script, st->codecpar, &inter);
     if (r < 0)



More information about the ffmpeg-cvslog mailing list