[FFmpeg-cvslog] avcodec/tta: fix signed overflow in decorrelate

Michael Niedermayer git at videolan.org
Mon Oct 30 02:10:31 EET 2023


ffmpeg | branch: release/5.1 | Michael Niedermayer <michael at niedermayer.cc> | Sat Aug  5 14:35:55 2023 +0200| [b91b26813c62e4a6e630dbf98486c0d48dd6f5c6] | committer: Michael Niedermayer

avcodec/tta: fix signed overflow in decorrelate

Fixes: signed integer overflow: 2079654542 - -139267653 cannot be represented in type 'int'
Fixes: 60811/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5915858409750528

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit 283bf5c35bc5ac92e061f27c3a680318175a1600)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b91b26813c62e4a6e630dbf98486c0d48dd6f5c6
---

 libavcodec/tta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/tta.c b/libavcodec/tta.c
index 0fc639b11c..c23439a2c0 100644
--- a/libavcodec/tta.c
+++ b/libavcodec/tta.c
@@ -341,7 +341,7 @@ static int tta_decode_frame(AVCodecContext *avctx, AVFrame *frame,
             if (s->channels > 1) {
                 int32_t *r = p - 1;
                 for (*p += *r / 2; r > (int32_t*)p - s->channels; r--)
-                    *r = *(r + 1) - *r;
+                    *r = *(r + 1) - (unsigned)*r;
             }
             cur_chan = 0;
             i++;



More information about the ffmpeg-cvslog mailing list