[FFmpeg-cvslog] avcodec/libvpxdec: Remove redundant unreferencing of AVFrame

Andreas Rheinhardt git at videolan.org
Tue Sep 19 19:11:33 EEST 2023


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Wed Sep 13 20:36:43 2023 +0200| [63eb630915b9ef92d21e521d610ed9d3ee2f358f] | committer: Andreas Rheinhardt

avcodec/libvpxdec: Remove redundant unreferencing of AVFrame

The AVFrame of a decoder with the ordinary decode callback
is generically unreferenced on error.

Reviewed-by: James Zern <jzern at google.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=63eb630915b9ef92d21e521d610ed9d3ee2f358f
---

 libavcodec/libvpxdec.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
index 72ef5fa9a7..c6187fd5a1 100644
--- a/libavcodec/libvpxdec.c
+++ b/libavcodec/libvpxdec.c
@@ -317,10 +317,8 @@ static int vpx_decode(AVCodecContext *avctx, AVFrame *picture,
                 return AVERROR(ENOMEM);
             if (ctx->has_alpha_channel) {
                 picture->buf[1] = av_buffer_ref(img_alpha->fb_priv);
-                if (!picture->buf[1]) {
-                    av_frame_unref(picture);
+                if (!picture->buf[1])
                     return AVERROR(ENOMEM);
-                }
             }
             for (int i = 0; i < 4; i++) {
                 picture->data[i] = planes[i];



More information about the ffmpeg-cvslog mailing list