[FFmpeg-cvslog] avformat/rtpenc_rfc4175: Use 64bit in computation if copy_offset
Michael Niedermayer
git at videolan.org
Fri Jul 12 17:53:03 EEST 2024
ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Sat Jun 8 00:13:59 2024 +0200| [f13ae632591b043cb69b66de01e8b178037cdd0e] | committer: Michael Niedermayer
avformat/rtpenc_rfc4175: Use 64bit in computation if copy_offset
Found while reviewing: CID1494441 Untrusted value as argument
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=f13ae632591b043cb69b66de01e8b178037cdd0e
---
libavformat/rtpenc_rfc4175.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/rtpenc_rfc4175.c b/libavformat/rtpenc_rfc4175.c
index 257d072cd3..2120274f01 100644
--- a/libavformat/rtpenc_rfc4175.c
+++ b/libavformat/rtpenc_rfc4175.c
@@ -116,7 +116,7 @@ void ff_rtp_send_raw_rfc4175(AVFormatContext *s1, const uint8_t *buf, int size,
int l_field;
int l_line;
int l_off;
- int copy_offset;
+ int64_t copy_offset;
length = (headers[0] << 8) | headers[1];
l_field = (headers[2] & 0x80) >> 7;
@@ -127,7 +127,7 @@ void ff_rtp_send_raw_rfc4175(AVFormatContext *s1, const uint8_t *buf, int size,
if (interlaced)
l_line = 2 * l_line + l_field;
- copy_offset = (l_line * width + l_off) * pgroup / xinc;
+ copy_offset = (l_line * (int64_t)width + l_off) * pgroup / xinc;
if (copy_offset + length > size)
break;
memcpy (dest, buf + copy_offset, length);
More information about the ffmpeg-cvslog
mailing list