[FFmpeg-cvslog] avfilter/af_aiir: Avoid unchecked allocation
Andreas Rheinhardt
git at videolan.org
Fri May 31 15:30:00 EEST 2024
ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Fri May 24 09:48:12 2024 +0200| [21bfc62642cb16fc3d867999db341d3c67e03404] | committer: Andreas Rheinhardt
avfilter/af_aiir: Avoid unchecked allocation
W has not been checked at all; allocate it jointly with M
to fix this.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=21bfc62642cb16fc3d867999db341d3c67e03404
---
libavfilter/af_aiir.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/libavfilter/af_aiir.c b/libavfilter/af_aiir.c
index 324fc367a3..7bd9e37e43 100644
--- a/libavfilter/af_aiir.c
+++ b/libavfilter/af_aiir.c
@@ -828,17 +828,17 @@ static int convert_serial2parallel(AVFilterContext *ctx, int channels)
double *impulse = av_calloc(length, sizeof(*impulse));
double *y = av_calloc(length, sizeof(*y));
double *resp = av_calloc(length, sizeof(*resp));
- double *M = av_calloc((length - 1) * 2 * nb_biquads, sizeof(*M));
- double *W = av_calloc((length - 1) * 2 * nb_biquads, sizeof(*W));
+ double *M = av_calloc((length - 1) * nb_biquads, 2 * 2 * sizeof(*M));
+ double *W;
if (!impulse || !y || !resp || !M) {
av_free(impulse);
av_free(y);
av_free(resp);
av_free(M);
- av_free(W);
return AVERROR(ENOMEM);
}
+ W = M + (length - 1) * 2 * nb_biquads;
impulse[0] = 1.;
@@ -877,7 +877,6 @@ static int convert_serial2parallel(AVFilterContext *ctx, int channels)
av_free(y);
av_free(resp);
av_free(M);
- av_free(W);
}
return 0;
More information about the ffmpeg-cvslog
mailing list