[Ffmpeg-devel] [PATCH] Add DESTDIR support to Makefiles
İsmail Dönmez
ismail
Wed Oct 19 09:26:33 CEST 2005
On Wednesday 19 October 2005 10:22, Sam Hocevar wrote:
> On Tue, Oct 18, 2005, ?smail D?nmez wrote:
> > > I must admit I find both your arguments quite esoteric. Tangible
> > > examples anyone?
> >
> > like -DCONFDIR=/etc/ffmpeg.conf in Makefiles and code using CONFDIR
> > variable then it will depend on conf_prefix and Sam's patch will break
> > it. But this is all "may be". Lets do things the right way pls? :)
>
> No. These -D flags are compile-time flags. DESTDIR is only specified
> for "make install" and is set to nothing during the build phase.
No but you change lib_dir, conf_dir in config.mak which is legal to use in
code. But for now its not used at all. But if someone uses that as variable
in code your patch would break. So I am not talking about _now_ but rather
future possibilities.
Regards,
ismail
More information about the ffmpeg-devel
mailing list