[Ffmpeg-devel] [PATCH] Remove special install path for MinGW.

[Måns Rullgård]

angustia at arrozcru.no-ip.org writes:

> Hello,
>
> Quoting Diego Biurrun <diego at biurrun.de>:
>
>> On Mon, Dec 04, 2006 at 10:57:38AM -0500, angustia at arrozcru.no-ip.org wrote:
>>> Quoting Diego Biurrun <diego at biurrun.de>:
>>>
>>> >On Mon, Dec 04, 2006 at 11:21:35AM -0200, ramiro at lisha.ufsc.br wrote:
>>> >>
>>> >>I haven't seen any other library that does this install path
>>> >>special-casing for Windows, and FFmpeg seems like it should be the last
>>> >>program to support such a thing.
>>> >
>>> >This is due to the way MinGW cross-compilation is handled in configure.
>>> >I've always been tempted to remove it.  In any case your patch is
>>> >incorrect as --prefix will no longer work correctly.
>>>
>>> I don't understand how it will no longer work correctly. My rationale
>>> was "let it be dealt with by default like it should be". Could you be
>>> more specific as to how --prefix will no longer work correctly?
>>
>> The value of --prefix is checked before, so setting PREFIX later will
>> hardcode it without allowing --prefix to override it.
>>
>
> I'm not setting PREFIX later. I'm just removing what used to be set
> later if !force_prefix.

[...]

>> Don't bother sending in a new patch with this hunk removed, though.  The
>> idea of your patch is incorrect.
>
> Sorry about the extra hunk. It was diff'd using the wrong tree. I
> believe the idea of my patch is correct, so new patch attached.
>
> If it still is really incorrect and I failed miserably to see where I
> went wrong, I'll give up for now.
>
> Ramiro Polla

Hey, look what I found in the revision history:

------------------------------------------------------------------------
r5531 | diego | 2006-06-27 08:38:57 +0100 (Tue, 27 Jun 2006) | 3 lines

Install into $PROGRAMFILES instead of a hardcoded path on MinGW.
patch by Ramiro Polla, ramiro86 %at% hotmail %dot% com

------------------------------------------------------------------------

Pay close attention to the patch author and committer...

Prior to that, the force_prefix thing was added in r4409 together with
some totally unrelated changes regarding IWMMXT.  The special windows
prefix was originally added by Fabrice as r2278 way back in 2003.

As far as I'm concerned, you may do whatever you want with that stuff.

-- 
M?ns Rullg?rd
mru at inprovide.com