[Ffmpeg-devel] [PATCH] Fix for url_fclose() being called on an already closed file

[Måns Rullgård]

Colin Ward <lists at codehq.org> writes:

> M?ns Rullg?rd wrote:
>>
>>>>>   While looking for a resource leak (which turned out to be in my own
>>>>> code!) I noticed that in libavformat/utils.c::av_open_input_file() it was
>>>>> possible for url_fclose() to be called twice in a row due to file_opened
>>>>> not being set back to 0 after the first call to url_fclose().  The chances
>>>>> of this are minutely tiny, but please find a patch attached anyway.
>>>> Could you set the mime type of attached patches to text/x-patch, please?  It
>>>> makes them easier to read.
>>> Well, text/plain would be even prefered by me, if it works for you as
>>> well...
>> Sure, text/anything is better than application/binary.  The advantage
>> of text/x-patch is that gnus will display it using diff-mode and
>> syntax highlighting.  That makes the patches easier to read.  Gnus
>> lets me display anything inline, but at work I have to use webmail and
>> it isn't as flexible.
>
>    I had a look at my mailer and it seems that it adds attachments as
>    application/octet-stream by default and there doesn't seem to be a
>    way to change this.  I agree that it is silly when you are
>    attaching a text patch.
>
>    I am going to make a feature request (its open source) and will
>    attach future patches from my work computer using a different
>    mailer.

Patches as application/octet-stream are better than no patches at
all.  Don't delay things for that reason.

-- 
M?ns Rullg?rd
mru at inprovide.com