[Ffmpeg-devel] RTP patches & RFC

[Luca Barbato]

Ryan Martell wrote:
> 2) Because I am using the RTPDemuxContext * in my handle function, I
> have to have that structure visible.  (It is currently private to
> rtp.c)  So I moved it into rtp.h.  Is this okay?  If we were to go with
> more of a function pointer/plugin structure, should I create a file
> called rtp_private.h (or something) to hold things that are shared among
> the rtp code, but nowhere else?

rtp_internal.h sounds nice...

> 
> 3) My sdp parsing code uses a few functions from rtsp.c: redir_isspace,
> skip_spaces, and get_word_sep.  These are all small functions, but I
> hate duplicating code. What's the best solution for this?  Make those
> functions non-static in rtsp.c?

if they are big and generic enough put a TODO:split near them for a
later patch.

> 
> 5) My code in rtp_h264 uses linked lists.  It creates packets, copies
> stuff into them, resizes them, etc.  It means at best 2 copies per
> packet (from the UDP buffer, to my packet, to the AVPacket), and at
> worst it could be many copies (I have to aggregate all of the packets
> for a given timestamp together).  My philosophy is "get it working, then
> make it fast.".  Are these acceptable issues?  I could keep a pool of
> packets around, but the payloads are various sizes.  Alternatively could
> set it up the way tcp handles it's streams, but that's a lot of pointer
> overhead and room for error.

Can't you work directly with AVPackets?
Can't you put some of this part in the framer layer?

(I know at least few people interested in h264/rtp beside me)

> 
> 6) Finally, I have a Base64 decoding routine for the sdp/pps packets
> that are sent in the sdp stream.  Does this exist elsewhere in the
> codebase?

not that I know.

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero