[Ffmpeg-devel] [PATCH] allow ffmpeg to read mp3s beginning with partial frames

[Michael Niedermayer]

Hi

On Thu, Sep 07, 2006 at 12:05:04AM +0100, Victor Voros wrote:
> Hi this is the first time im posting here  so apologies if format is
> wrong etc.
> 
> Some mp3s I have begin with partial frames before the first
> Sync frame. WMP and ITunes handle them OK but SVN FFmpeg does not. Can
> send several examples of mp3 files that are like this.

yes, a sample which shows the problem would be needed


> 
> Attached is a patch to libavformat\mp3.c which addresses this in diff -u
> format from head (6180)
> 
> Simply scans the file looking for a sync frame and starts there if
> found.

rejected, this does not belong in libavformat, demuxers should output
whats in the file, not do codec specific parsing and discarding of stuff
such code should be in the parser or decoder

furthermore, the line endings in your patch look bad


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is