[Ffmpeg-devel] [PATCH] Add kibi, mibi and gibi support

[Panagiotis Issaris]

Hi,

Op zondag 17 september 2006 13:11, schreef Michael Niedermayer:
>[...]
> > > The attached patch tries to integrate my patch with your commit 6284. In
> > > fact, I am ripping most of your code and putting it in the av_strtod()
> > > function, reusing it for your eval.c code. Regression tests succeed.
> > > 
> > > "./ffmpeg -i src.avi -b 1000hi dst.avi" now also works :) 
> > > (nicely shows 101kb/s)
> [...]
> > +    /* if requested, fill in tail with the position after the last parsed
> > +       character */
> > +    if (tail)
> > +        *tail = next;
> >      return d;
> 
> why not put the whole under if(next != name){ ... }
> instead of the if(next == name) special case?
Absolutely right, as this would remove the need for the duplicate "if (tail) *tail=next; ...".
Fixed in the attached patch.

> [...]

 libavcodec/eval.c   |   37 -------------------------
 libavcodec/opt.c    |   75 +++++++++++++++++++++++++++++++++++++---------------
 libavformat/dvenc.c |    0
 3 files changed, 55 insertions(+), 57 deletions(-)

With friendly regards,
Takis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20060918T111029-ffmpeg-av_strtod_eval_integrate-v3.diff
Type: text/x-diff
Size: 3715 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060918/4ffc4db7/attachment.diff>