[Ffmpeg-devel] [PATCH] Use ff_eval for AVOption parsing

[Panagiotis Issaris]

Hi,

Op woensdag 27 september 2006 00:26, schreef Michael Niedermayer:
> > > Follow-up patch attached which makes ratecontrol use ff_eval2.
> > > Regression tests succeed.
> > > [...]
Okay to commit this one? This would allow me to quickly fix [1], as the 
version bump came earlier then expected.

> > 
> > Should I have put this (in mpegvideo.h):
> >  994 double ff_eval(char *s, double *const_value, const char **const_name,
> >  995                double (**func1)(void *, double), const char **func1_name,
> >  996                double (**func2)(void *, double, double), char **func2_name,
> >  997                void *opaque);
> > 
> > Within this too?
> > #if LIBAVCODEC_VERSION_INT < ((51<<16)+(16<<8)+0)
> > ...
> > #endif
> 
> yes probably
> well actually the whole ff_eval doesnt belong into mpegvideo.h ...
A separate eval.h containing just ff_eval/ff_eval2?


With friendly regards,
Takis

[1] http://article.gmane.org/gmane.comp.video.ffmpeg.devel/37476